Tomáš Mlynarič

Results 20 comments of Tomáš Mlynarič

1) I understand that you don't need the library to do this and can somehow set fields manually, but since Dagger allows this, doesn't AssistedInject kind of breaks the feature?...

I agree, members injection seems like a terrible thing. The reason is android ViewModel with inheritance: - we have "pure" Dagger with ViewModels - all ViewModels inherit from some `BaseViewModel`...

I see the issue. I was thinking, that it would be possible to extend the pure AssistedInject processor to generate the code, but then not sure, how to pass the...

AFAIK, you don't have to run this on RPI .. you can run it on your PC once to pair with the TV which will give you username and password

Hello, any update on this? (it's been quite some time :( )

100% percent agree, it is even more problematic now, when android studio 3.4 is stable and gradle 5.1+ needs to be used (issue here https://github.com/awslabs/aws-mobile-appsync-sdk-android/issues/91 ) .. and this prevents...

I wonder why all the dependencies are marked as `compileOnly`. This is what's causing the problem.

Now in Android doesn't use Baseline Profiles Gradle Plugin (yet). I think we should keep the build type until it's implemented. @keyboardsurfer WDYT?

> If it is because you are in the middle of a refactoring searching for the string `"mKey"` will do the trick (but of course you need to check it...

Ok, fixed the randomness and testing if author is already checked. I regenerated the BLP profiles after the fixes with interesting numbers: **BEFORE** ``` StartupBenchmark_startupBaselineProfile timeToFullDisplayMs min 468.0, median 516.8,...