Michel Loiseleur
Michel Loiseleur
LGTM, Thanks for this PR :+1:
@fopina both. Yes, you can rebase. Another maintainer will review it before merging.
@fopina You need to rebase again (or allow us to rebase it) before we can merge it.
@rndmh3ro Thanks for taking the time to save others from getting the same shock :). You'll need to update the tests accordingly.
Hello @aacebedo, It's not implemented but it's a feature that can be added by using `tpl` in https://github.com/traefik/traefik-helm-chart/blob/master/traefik/templates/ingressroute.yaml Feel free to open PR if you need it.
It does not seem to be documented, but yes, it seems it's missing.
_get_ is not required on namespaces, AFAIR. Feel free to open a PR, the maintainers will review it ASAP.
I located other issues when testing this one, so I took the time to open a PR (#1596). You are welcome to review and/or test it.
This refactor makes sense to me.
@bachorp We will release next week. If you can test (and rebase) this PR before, maybe it will make it. Otherwise it will be for the next release.