Michel Loiseleur

Results 716 comments of Michel Loiseleur

:warning: There are still many pages with links to hidden pages in the current build. ```bash WARNING - Documentation file 'migrate/v2-to-v3-details.md' contains a link to 'providers/kubernetes-crd.md' which is not found...

Yes. As you know, it's quite boring task. I'll probably do another pass tomorrow. Any help on this is welcome :).

@nmengin Solved with my last commit. I found an efficient way to tackle it.

Thanks. I'm not sure of this approach :thinking: It may increase memory usage on big users. /ok-to-test cc @szuecs

What happens the txt record has also been deleted ? It will still be in this cache, so not re-created ?

@u-kai I prefer to fix it in a dedicated PR. Maybe we can add +100 to the second one, and so reach the 0% chance of collision without any overlap...

This PR can be tested following [those instructions](https://github.com/kubernetes-sigs/external-dns/blob/master/CONTRIBUTING.md#how-to-test-a-pr). @nitinkeswani Can you confirm it fixes your issue ?

@vflaux @mrozentsvayg Any comment on this PR ? Do you think you can review it ?

@AndrewCharlesHay Would you please rebase ?

@vflaux @szuecs Anything left on your side ?