Michel Loiseleur
Michel Loiseleur
I have built and tested this PR on a sandbox environment for our use case. ~~Maybe it works for `AWSManagedMachinePool`, but it does not support `AWSManagedControlPlane` with `MachineDeployment` and `EKSConfigTemplate`.~~...
@AmitSahastra I've done a review with a [commit](https://github.com/kubernetes-sigs/cluster-api-provider-aws/commit/546432d3cce8755cf3071612afa6e169793523ec) on my fork https://github.com/mloiseleur/cluster-api-provider-aws/tree/al2023-launch-template What I've done: 1. Fix maxPods (it was setting to 58 when setting the boolean in the CRD...
@jnoordsij If you think we should not do it, it's still time and possible to explain why !
Damn it, that's right. It will break many configuration with the dependency :warning: ! And without the dependency, the install instruction needs to be changed, it won't work out of...
> Add the CRDs as templates within the chart like in the cert-manager chart This morning, I have explored this option. I have encountered two major issues: 1. On **install**:...
Additional notes: * Helm maintainers have started to work on Helm v4, see [here](https://github.com/helm/community/blob/main/hips/hip-0012.md). * CRDs management are [discussed in the roadmap](https://docs.google.com/document/d/1WJ3K96fJeldKHoKhejWHDvCOTddEvY-RCtQBUaZ57FM/edit?tab=t.0). Helm maintainers have also detailed why it's working...
Following this last review, the behavior observed when using the dedicated crd chart as a dependency is clearly not satisfactory: - it's not possible to use CR like the Dashboard...
/ok-to-test
A maintainer will review it when he has time for final approval. The istio provider will move away from the tree, anyway. We have started [the process](https://github.com/kubernetes-sigs/external-dns/issues/4347) [to move the...