Michel Loiseleur

Results 571 comments of Michel Loiseleur

This field is present [in the CRD since v1.0.0 of cert-manager](https://doc.crds.dev/github.com/jetstack/cert-manager/cert-manager.io/Certificate/[email protected]), so I guess this change is safe. /lgtm

@redbaron I think we have already (a lot) of flags. Without thinking too much about it, as a user, I'll probably prefer to use a config file or a CR.

At first glance, it looks like it will generate (potentially) many logs for the same CLI switch. Since this is the explicit purpose of this policy, I am not sure...

The code lgtm. I'm unsure if we should do it or not. I have not a strong opinion on this subject. I'll let @Raffo make a final decision on this....

Thanks for this @arontsang :+1: Do you think you can add some tests on this ?

/retitle fix(crd): txt record deletion

@ivankatliarchuk anything left on your side ? @mcharriere @mrozentsvayg Do you think one of you can proceed with a final review ?