Michel Loiseleur

Results 554 comments of Michel Loiseleur

@hjoshi123 On RFC2136 provider, there is a test ensuring that all parameters are effectively taken into account, see https://github.com/kubernetes-sigs/external-dns/blob/8a69069c36b156d3e16795d31a3fba6c41204050/provider/rfc2136/rfc2136_test.go#L425-L495 Wdyt of doing the same for aws provider ? > Hmm.....

sure, it sounds good.

/retitle feat(aws): multiple zone roles

@hjoshi123 Would you please update documentation accordingly to show how it can be used ? /ok-to-test

> @mloiseleur what do you think we should do with this PR? I am not sure how to proceed. I have mixed feeling about it, TBH. I understand from your...

> This patch looks like a very simple way to solve that need in a way that should meet the requirements of most central infra teams. Yes it is. It...

@TroyKomodo This subject has already been discussed see https://github.com/kubernetes-sigs/external-dns/pull/4574#issuecomment-2286040002: > We are discussing external-dns change in https://kubernetes.slack.com/archives/C771MKDKQ/p1723531094274339 and the InternalIP/ExternalIP topic was discussed in https://kubernetes.slack.com/archives/C09QYUH5W/p1723197933110369 . sig-network tech-leads said that...

/ok-to-test Please remove the content of `devcontainer.json` of this PR. You can submit it in an other PR.

/retitle feat(cloudflare): support cloudflare region

It looks better, now :+1: . Would you please rebase and add some documentation on how to use it ?