Michel Loiseleur

Results 566 comments of Michel Loiseleur

I took the time to look at which providers are unmaintained. Here is a first list: - [rcode0](https://github.com/kubernetes-sigs/external-dns/commits/master/provider/rcode0): 4 years - [vinyldns](https://github.com/kubernetes-sigs/external-dns/commits/master/provider/vinyldns): 4 years - [dyn](https://github.com/kubernetes-sigs/external-dns/commits/master/provider/dyn): 3 years - [vultr](https://github.com/kubernetes-sigs/external-dns/commits/master/provider/vultr):...

I get your point for the documentation. It makes sense.

@Raffo @hans-m-song Considering that: 1. `external-dns` is probably more near v1.0 than when those annotations where introduced, 2. _webhook_ is (now) how a provider should be implemented Wdyt of naming...

This fix looks correct to me.

@johngmyers I agree with you that default behavior should work out of the box and I also agree with @szuecs that this behavior may cause unexpected issues. => I suggest...

I have tested it with a build of this PR that I published [here](https://github.com/users/mloiseleur/packages/container/package/external-dns). I can confirm that: 1. It should be documented in `doc/tutorials/aws.md`, since it works following this...

@johngmyers Since #3824 is merged, with ambassdor going to v1.12.4, is there still an interest to keep this PR ?