Michel Loiseleur
Michel Loiseleur
Since author is not answering, I'm closing this PR. Feel free to re-open it or open a new one if you need it. /close
sure, no problem /reopen
/ok-to-test /retitle feat: add annotation and label filters to Ambassador Host Source
/lgtm /label tide/merge-method-squash
@KyleMartin901 This PR has been approved. It means that it just needs a rebase, to pass tests and it will be merged.
@phillebaba Do you think you can rebase this PR ? The CI is now fixed.
@phillebaba I left one small suggestion on error handling, otherwise it LGTM.
Hello, #3063 has been merged. All new providers needs to use this webhook mechanism. @EIP-Laurent You can rebase on a new repo this provider, using this mechanism. => I'm closing...
Now that webhook provider is available in public version of `external-dns`, I think this PR can be closed. Feel free to create a webhook provider on `designate`. /close