Michel Loiseleur

Results 607 comments of Michel Loiseleur

This will clearly help users :+1:. /approve

@szuecs Thanks for your review. For your other comments, the problem is the way it works currently. The README.md is used as front page doc on https://github.com/kubernetes-sigs/external-dns It's also [copied...

@Enelar Comment @hzux is a good first step. Please also be aware that we have started [the discussion](https://github.com/kubernetes-sigs/external-dns/issues/4347) to move providers out of tree.

1. Since it's only needed for records, instead of modifying the wrapper, wdyt about using this parameter in `godaddy.go:229` ? ```go if err := p.client.Get(fmt.Sprintf("/v1/domains/%s/records", zone), &recordsIds); err != nil...

Thanks for this PR @haslersn ! Wdyt about adding some documentation on [registries](https://kubernetes-sigs.github.io/external-dns/v0.14.1/registry/registry/) about this ?

Thanks for this PR. The test looks good. Would you please add: 1. some documentation on this 2. an other test with multiple `cloudflare-proxied` domains I'm unsure to understand why...

Thanks @Tazer, it's clear. You made quite a good job in order to avoid a breaking change :+1: . I have to admit also I have doubts about this approach...

The successful run is publicly available here: https://github.com/mloiseleur/clients/actions/runs/7298251623 If you scroll down a bit, you can access to artifacts generated: ![image](https://github.com/bitwarden/clients/assets/97035654/6a59d572-b50f-4201-9807-8ff2ecd287aa) Direct link [here](https://github.com/mloiseleur/clients/actions/runs/7298251623/artifacts/1130788584).