Matthew Lohbihler

Results 11 comments of Matthew Lohbihler

The problem is that we are already using `Oj.load` for parsing of DateTimes and such. But the documents are externally generated, so we can't depend on having leading ":" and...

> @mlohbihler the code looks good. could you add information in README & write tests for that. thanks Done. Please have another look when you can. Note that i added...

@jalkoby , can you please have another look?

Hmm, interesting case. I will take a look. Does this happen often? I've never seen this before.

Turns out there were a few problems with segments being received out of order. I committed a fix for this here: https://github.com/infiniteautomation/BACnet4J/commit/381b6f67e8c853b262f0411330a652d318c89e99

I suspect that YABE is returning a Boolean value instead of a BinaryPV.

The spec is very, ... well, specific about datatypes. The binary types (input, output, and value) all use a BinaryPV as their present values. Booleans are only used as service...

Code in src_test is deprecated, and may not work. There has been no effort to update it along with the main source. The preference has been to create unit tests...

How are you adding them? Can you provide some code?