squasher icon indicating copy to clipboard operation
squasher copied to clipboard

Published 20 hours ago • verified publisher icon jalkoby

Allow multiverse

Open mlohbihler opened this issue 4 years ago • 4 comments

As per issue #68, this PR allows multiverse to be present by allowing the user to specify other database keys that should be loaded. There is also a change to Squasher#print that prevents failures due to there being '%' characters in the generated schema (such as in comments).

This PR however does not provide for the squashing of non-default databases.

mlohbihler avatar Nov 26 '21 23:11 mlohbihler

Hi. thank you for contributing. I need to review code - will do a bit later

jalkoby avatar Nov 30 '21 11:11 jalkoby

@mlohbihler the code looks good. could you add information in README & write tests for that. thanks

jalkoby avatar Dec 14 '21 12:12 jalkoby

@mlohbihler the code looks good. could you add information in README & write tests for that. thanks

Done. Please have another look when you can. Note that i added a message to CHANGELOG instead of README because the latter doesn't contain any switch-specific information, and adding such for just this one switch seemed out of place.

mlohbihler avatar Dec 23 '21 21:12 mlohbihler

@jalkoby , can you please have another look?

mlohbihler avatar Feb 10 '22 22:02 mlohbihler

so... I really forgot to look at the comments. sorry - it's pushed

jalkoby avatar Nov 15 '22 21:11 jalkoby