Mike Lin

Results 238 comments of Mike Lin

@vsmalladi Thanks, agree- I'd say the definition of passing the test should allow `"username": null` to be either present or absent.

Yes, here is the plan to make a plan. Right now I've been focusing on some "meta" technical debt, especially #668. That's going to be equally important to keeping the...

@williamrowell Eventually but not in the short term, so adding it to miniwdl-slurm sounds right to me. You will need to add processing for the new attributes in the override...

@williamrowell Cool, thanks for the update! > Is this something you'd be interested in accepting as a PR on miniwdl-slurm? Let me ping @rhpvorderman @DavyCats here who led its development....

Since the high-level create method doesn't expose a way to directly insert DeviceRequests into the ContainerSpec it builds, the most straightforward way to achieve your goal is to use the...

Thanks @markjschreiber, I think this is closely related to #669 which has a fix on the main branch (but not yet released)

> so it's hard to tell what *should* happen here. Agree this isn't crystal clear from the spec, and the current miniwdl implementation takes a hard line in making any...

Just looked into this a little and found a relevant check commented out, https://github.com/chanzuckerberg/miniwdl/blob/7344a900f408c2703e4dc4504c42a4f1d1844984/WDL/_parser.py#L63-L67 Sooo, I need to figure out if that was an oversight or what... 😅

FWIW here's where we take care of the equivalent blocking-and-tackling (short of the semantic questions discussed above) of defining error responses in our API: https://wiki.dnanexus.com/API-Specification-v1.0.0/Protocols#Errors Then, our individual API methods...

subsumed by https://github.com/chanzuckerberg/cellxgene-census/pull/1354 (wip)