mleot
mleot
I also have motivation to add more integrators to OpenPNM. I can help out with writing some of these unit tests.
@tinosulzer just bumping this comment again to see if you had any ideas On Thu, Dec 21, 2023, 1:57 PM Tanner Leo ***@***.***> wrote: > ***@***.**** commented on this pull...
@rtimms Okay I believe everything here is in working order. Is an example notebook necessary? What else do I need to do before it can be merged into develop?
Thanks for walking me through it! Hopefully the next one goes smoother!
@llh929423719 can you provide more details on the specific base parameter set, the experimental protocol, the model used, and the solver? I would like to try and replicate the error...
Hi @ejfdickinson, thanks for these comments. You make a fair point - as I was writing the code for this, I realized that realistically the current which is impacting the...
@ejfdickinson Thanks for the suggestions. Regarding your first suggestion: I think is a neat implementation of this portion of the equation. Regarding the second suggestion: Is this specific equation referenced...
Referring to @rtimms for advice on difficulty of implementation
I would be happy to help! @rtimms If you want to set up the new class structure that would be very helpful!
I had some trouble implementing the custom function parameters mentioned in this issue. Implementing the initial state was fairly easy to implement, however. I will propose that the initial hysteresis...