mlemesle

Results 40 comments of mlemesle

Hello everyone ! I’d like to contribute to Meilisearch and this seems to be a good first issue ! May I ask if @knidarkness is still working on it to...

Hey @curquiza ! Thanks for letting me contribute, this is a great opportunity ! I got an issue though. The toml config file shown as an example is partial, all...

Hi @Kerollmops ! Thanks for your quick answer ! I think #[serde(default = "path")] might be relevant, however it’s the path to a function, not a value, so I’ll have...

Hey ! I finished setting all the default values for serde. The config file now works just fine :) However, I'm not sure about the sections in the config file....

Hey ! PR is ready for review ! 🙂

Hey @curquiza ! I just added a default toml file with "comment sections". Everything is commented so it’s less prone to errors for clients, they just need to uncomment the...

> Thank you again @mlemesle for the PR!! > > About the config file sections, I'm not sure every option has to be in a section. For example, you can...

Hey everyone, I just commited (if I let nothing slip) all the changes regarding your comments. @maryamsulemani97 The doc I copied is the one from the executable from Meilisearch. It’s...

> Hello again! > > I talked with the core team and @maryamsulemani97: no need to apply any change on the default config file anymore. We are sorry not to...

> > No problem at all ! Regarding the error message, if I understand correctly you want this message to be printed only when a specific file is used by...