Michael Cui

[lit-html] classMap is significantly slower than manual class manipulation in js-framework-benchmark

2

(Note that all of this is based on an **artificial benchmark with no warmups**, so take these results with a grain of salt when assessing real-world performance. This also may...

`git sync` while on non-detached `main` causes a `git checkout main` for every stack

2

### Description of the bug This causes `git sync`s to be significantly slower, especially if `git checkout main` takes a while. This isn't usually the case, unless you're in a...

`git branchless init --main-branch <branch>` does not set main branch if set in `.git/config`

1

### Description of the bug This is a pretty obscure bug: Command log ``` $ git sl The application panicked (crashed). Message: A fatal error occurred: 0: Could not find...

Aborting a rebase started by `git sync --merge` then `git undo -i` deletes the main branch

1

### Description of the bug See command log below: Command log ``` $ git init sync-abort $ cd sync-abort $ git commit --allow-empty -m "Initial commit" [main (root-commit) 6dfb64b] Initial...

Issues when restacking merge commits

1

This is a combination of a few issues relating to restacking merge commits. Expand the below to see logs: Rewriting an ancestor of a merge commit makes git restack a...

Creating working copy snapshot panics with directory symlink ending in '/'

1

### Description of the bug Reproduction: ```shell $ git init symlink && cd symlink Initialized empty Git repository in ~/git/symlink/.git/ $ mkdir dir && touch dir/file.txt && git add dir/file.txt...

If `@` turns immutable, it can still be mutated

8

## Description If `@` somehow turns immutable - for example, if `immutable_heads()` contains `remote_branches()`, and `@` is pushed - `@` can still be mutated. GitHub's "[Adding new commits](https://martinvonz.github.io/jj/prerelease/github/#adding-new-commits)" workflow discourages...

windows: avoid UNC paths in `run_ui_editor`

1

~~**This PR depends on #3995. Please only review the last commit until that PR has been merged.**~~ See https://github.com/martinvonz/jj/issues/3986 for more details. This is a no-op for non-Windows. # Checklist...

This is acknowledged in [the documentation for `std::fs::canonicalize`](https://doc.rust-lang.org/std/fs/fn.canonicalize.html#platform-specific-behavior): > On Windows, this converts the path to use [extended length path syntax](https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file), which allows your program to use longer path names,...

## Steps to Reproduce the Problem ``` $ jj @ qont three (merge) ├─╮ │ ○ tpzo two ○ │ wouy one ├─╯ │ ○ vzkp four ├─╯ $ jj...