Mattia Lavacca

Results 181 comments of Mattia Lavacca

That test is somewhat specular to the one I'm suggesting here: * The `HTTPRouteDisallowedKind` test creates an HTTPRoute with a ParentRefs that doesn't accept that kind of route (in that...

> I'm having an issue passing this test as the test is requiring the Gateway ListenerStatus SupportedKinds array to be empty. The CRD does not permit an empty array to...

The `kinds` field you pointed out above is in the listener spec, while the `supportedKinds` is in the listener status. In this case, no `kinds` specified in the `allowedRoutes` matches...

@rperper I actually was looking for the Gateway Status that triggers the error, can you add the Status section in the snippet above? Reading from the log, `status.listeners[0].supportedKinds` looks like...

@youngnick @shaneutt Reading from the GEP #1383 that has recently merged, I see that has been decided to always enforce the Gateway conditions, even when true. Do you think I...

> TBH I don't get the use case. Seems like each impl will make pick `controllerName` as a constant, and if its invalid they will pick a new one? Not...

I'm not sure why, but re-asking the review to @howardjohn, @sunjayBhatia, and @akankshakumari393 removed the review request to @mikemorris and @keithmattix. The PR is ready for review and all the...