Martin Kustermann

Results 193 comments of Martin Kustermann

> We already built that once: https://dart-review.googlesource.com/c/sdk/+/240847 I was hoping there's a way to do this more efficiently than what that CL does (e.g. load from segment register, store into...

Something fishy going on with the imports - possibly due to this `sdk_rewriter.dart` tool, I'll have a look later.

Not sure why some things fail here and not sure whether it's worthwhile to debug. Web/Interop team seems open to my suggestion on https://github.com/dart-lang/sdk/issues/55183 / https://github.com/dart-lang/sdk/issues/55187 - if a new...

It appears some existing flutter web engine code uses the`toJSAnyShallow`/`toObjectShallow` API despite it actually wanting a deep conversion (it happens to work in dart2js - as dart objects are JS...

@eyebrowsoffire I've made the PR now only affect finalizer code (which I saw on cpu profile), ( thereby not affecting other `.toJSAnyShallow` call sites that may actually require deep). Let...

> I've noticed that these tests are flaky for dart2js and DDC when running on Firefox and Safari even though they all use the TouchEvent constructor which is not present...

@nshahan @sgrekhov The `asyncStart` / `asyncEnd` machinery works perfectly fine here. The fact that the tests fail on some browsers should also be perfectly fine (so we shouldn't change the...

> If there is nothing to tests in some brausers why the tests should fail? And the change (already commited but I can revert it if needed) should fix the...

> Documentations of Int64 and its members are copied directly ... > It looks like analyzer can't handle the conditional import properly ... Consider making `Int64` an abstract class with...