Martin Kustermann

Results 193 comments of Martin Kustermann

> (The validations listed in https://github.com/dart-lang/native/issues/1409 can be run in the hook implementation and throw there already. Though we should also validate these in the builder.) The protocol is json...

> If we blindly invoke the build and link hooks, we might get longer running builds for asset types that are not going to be hot-reload. E.g. hot reloading data...

> I believe the caching would not work in that case. The cached results of fragment-shader and image from the main build would not be reused in the first hot...

As a side note: We should also ensure that dependencies (e.g. `.d` files) are recorded for each asset and not on a global level. This will ensure that if the...

Would it make sense to go away from "native" and from "assets" and instead use `package:dart_build` / `package:dbuild` / ...?

Whatever compiler flags `dart build` and `flutter build` may pass down to individual `hook/build.dart` scripts. The hook scripts themselves will use a helper package e.g. `package:native_toolchain_c`. Now `dart build` and...

> The BuildConfig and LinkConfig don't have an arbitrary compilerFlags field. Maybe it should? Currently, there's only BuildMode.release/debug. If we (in the future) want the ability to statically link the...

> The --debug flag does not seem to work for dart2wasm either. That is probably the root cause of this The Dart2Wasm compiler is only used for `--profile` / `--release`...

> We may want to add an error message if someone attempts to use --wasm and --debug together, it is currently not a valid combination. @eyebrowsoffire Currently `flutter run -d...