Martin Kustermann

Results 193 comments of Martin Kustermann

> addDependency already enables specifying a directory. However, we do not have a recursive option. Do we need a recursive option or should we simply tell users to use package:glob...

> I believe build.dart and link.dart should consider dart compile js the same as flutter build web and dart compile wasm the same as flutter build web --wasm `dart compile...

> Terms like "product mode" I believe only make sense to those that work on implementing the SDK. I think they are different for historical reasons. The name "product" does...

See https://github.com/dart-lang/sdk/issues/55979#issuecomment-2160451730 If flutter also releases a new stable with this CP in, it may need to cherry-pick: * in engine https://github.com/flutter/engine/commit/1f3938d80e6e60dd02b70b71a940f84a1d519c57 & https://github.com/flutter/engine/commit/ae9e09285c8a6b73d6d6a47652d8cc835639a1e1 (get rid of `dart.library.ffi` conditional imports...

See repro: [binaryen_arrayalloc_issue.tar.gz](https://github.com/user-attachments/files/18884769/binaryen_arrayalloc_issue.tar.gz) We compile via ``` % tar xvzf binaryen_arrayalloc_issue.tar.gz output.wasm output.wat output.unopt.wasm output.unopt.wat % wasm-opt --all-features --closed-world --traps-never-happen --type-unfinalizing -Os --type-ssa --gufa -Os \ --type-merging -Os --type-finalizing --minimize-rec-groups...

> I'm not sure if uri.path is supposed to work this way, investigating.. I think that's somewhat expected, a `Uri.file(r'c:\A\B.txt, isWindows: true)` will have a * `Uri = {.scheme =...

> That could work, but that requires us to do this in multiple places: I could imagine having some helper function somewhere that invokes this `envScript` with `envScriptArgs`, sees what...