Martin Kustermann

Results 193 comments of Martin Kustermann

> Eco system fragmentation > hook/{build,link}.dart scripts that require flutter specific things. > > This sounds like an anti-pattern to me. Did you mean "hooks that can use flutter-specific things"?...

> Yes, so this responsibility of correctness moves from the BuildConfig class to the bundling tool / embedder. > The embedder has to not forget to check that after the...

> We need to be careful to avoid having a different version in the Dart SDK then in the Flutter SDK during branch alignment. Otherwise the Dart language constraint is...

> > A package may work in flutter and non-flutter. It can use conditional imports to do different things in flutter vs non-flutter. > > Do we really want to...

> Can't an SDK constraint Dart be enough? That'll pretty much guarantee that you get at-least the corresponding version of the Flutter SDK. That's what we'll do for now, yes....

> But should this not be android-specific instead of flutter specific? It sounds like package:flutter_android_java_crypto_apis should be called package:android_java_crypto_apis and not be a plugin but a dart:ffi package... Theoretically, yes....

Thanks for the initial round of feedback, @mosuem! PTAL

> Cons for String: > Requires doc comments to even specify that they are a file path, could be a file name, or some other contents. It's usually very obvious...

> I thought the benefit of a typed language is to not have to infer the type from the name ;) Name of variables should signal what the variable represents...