Moritz Küttel

Results 11 comments of Moritz Küttel

I tested the performance using this patch ``` diff --git a/src/sacy/ext-translators.php b/src/sacy/ext-translators.php index 8cfbf83..c39c89e 100644 --- a/src/sacy/ext-translators.php +++ b/src/sacy/ext-translators.php @@ -18,6 +18,7 @@ abstract class ExternalProcessor{ } $cmd_string = implode('...

Maybe this should be targeted at 4.6, but IMHO since it fixes nested transactions for when using phpunit which uses the SQLite3 driver by default, and nested transactions are clearly...

Ah thanks for your quick and detailed feedback! I clearly overread the important part here with the outermost transaction. That basically means, "Yes you can nest transactions, but we don't...

I might be able to implement this as well for PostgreSQL which seems to suppor the same savepoint syntax, but I have no access or experience to the other database...

I've now implemented most of this on the BaseConnection directly, while also providing a configuration option with the very verbose name `enableNestedTransactions`. Nested transactions should now be supported by mysqli,...

I'll now wait for some feedback, before cleaning up everything to hopefully make it ready to merge.

this should fix most if not all of the linting mistakes

I've now added some more tests and the `transNested` function (better names are welcome), which sets enableNestedTransactions. I'd like to make it private, but I want to be able to...

I've added some fixes for the tests and I'm getting a clearer picture now. But I've been thinking about another thing: strict mode. Strict mode is turned on by default,...