Michał Kowalczyk

Results 213 comments of Michał Kowalczyk

I wasn't following this topic closely, but AFAIR the biggest perf problem for EDMM was that we had to fault every page separately when loading the enclave/allocating memory. Does that...

> use them as a display It seems it's not a vital feature for your case then? Also, if you're using allowed files, then adding this to trusted files only...

I like this idea, seems more portable than what we currently have and still simple. @dimakuv, @kailun-qin: Do you see any potential problems with going this way?

> > we don't need to "sleep" for this to work, we use consecutive calls to gettimeofday() and the time elapsed between them to make the calculation. > > Do...

> How do we account for the latency of the `gettimeofday()` ocall itself? But I guess, if we "wait some time" and this time is long enough, then we can...

@jonathan-sha: Let's move the discussion about these points to the PR review, so we can discuss them next to the code (and in a single place).

Yeah, I remember about it, but I was quite busy recently with other stuff. I have some more time now, so I'll continue the review now :)

@jonathan-sha: Could you reply to all the discussions in Reviewable? There are a few of them from Dmitrii which you left unanswered and it's not obvious whether you fixed the...

Hey, glad to hear you still want to contribute, you wrote quite good code! @woju: Do we have any machines with SGX to which we could allow external access? Note...