Marcin Kosieradzki

Results 31 comments of Marcin Kosieradzki

I have implemented one a month ago and I am considering sharing it on GH. However it uses Azure Key Vault in its current implementation so it’s not as generał...

Sorry for confusion. This header is propely set from the standard Host header provided to the Reverse Proxy and that's definitely proper behavior.

From my experiments: 1. X-Forwaded-Host is set based on Host header sent to proxy (and that's correct) 2. If X-Forwaded-Host header is added, there are two X-Forwarded-Host headers that might...

@BharatNarasimman I assumed that this appended value is actually from second header. But yes that's extactly what I am observing. I also have interpreted this as incorrect behavior, however I...

Just to make sure that one important option is not removed. I am changing inide all sfprojs DefaultTargets to "Package". It's very important because I am building multiple Service Fabric...

@jskeet Thanks for your answer. I have created a prototype and it actually uses a separate IAsyncMessage :) interface to prevent breaking compatibility with existing code. Regular async methods are...

I see you point. However I am not sure whether Unity isn't going towards .NET Standard as well (but I don't use Unity). OK. So we basically expect different things...

If you really think it's not pointless to do async without ValueTask in this specific case, then I can create a PR with the 1st step of my Proposal (except...

@jskeet Do you think using partial classes and moving all async code to ,Async.cs is a good idea? I've seen this pattern in multiple projects that wanted to retain .NET...

I have created a PR to help tracking changes. The current code is focused on correctness - not performance. Feel free to drop any comments.