Mehmet Korkmaz comments

Results 4 comments of


                                            Mehmet Korkmaz

Does this library still work? I do not think so, looks like FR24 disabled public API access...

Actually they changed their api, this library is no more usefull. I'll update the docs

RedisJson::createWithPhpRedis() must be an instance of Redis, instance of RedisCluster given

I believe latest version must be support that: [https://github.com/mkorkmaz/redislabs-common/blob/master/src/RedisClient/Redis.php#L13](https://github.com/mkorkmaz/redislabs-common/blob/master/src/RedisClient/Redis.php#L13) But this library not fully tested against a redis cluster. It is highly possible you'll see "MOVED" responses since on the...

Path format must be checked and validated.

Hi @aliozinan Basically redisjson-php just uses what redis clients provide. Selecting db should be done on redis client level if needed. So I don't expect any issue about it. But...

feat(dev) Support query predicates for graph commit command

I'll try to review this in a couple of days. I have ideas that can be applied after this PR.