Max

Results 111 comments of Max

> > Maybe we can add a size argument to braket? > > Hi - that's a great idea. Feel free to open a PR:) However, I noticed Typst's `lr()`...

> I'm REALLY unsure about `layout_symbol`... I'm not really familiar with the layout code, and this change just made it work, but I think a single symbol should maybe be...

> With this, the tests are now passing, but `layout_symbol` remains unable to handle multi-`char` values. As mentioned in [#6489 (comment)](https://github.com/typst/typst/pull/6489#issuecomment-3054359355), I think it needs to be able to handle...

> Yeah, this can probably also come up in more complicated scenarios with other grapheme clusters that could perhaps even no longer be single grapheme clusters after the replacement. >...

> Does this imply that `#[#figure(...) abc def g] ` will label the figure rather than the combination of the figure and the text? No, it will label the text...

You're right, there is then now the issue with StyledElem when queried and placed again losing its styles. I think this could then be resolved by not peeking into StyledElem...

Not very urgent, everything appears to work just fine using the "math" script tag so it shouldn't block the PR.

> A possible fix could be to assert that identifiers in math aren't single grapheme clusters, but I would want a second opinion before deciding on it. I think this...

> A related case: the single letter test also fails when using something like φ̅ (where a φ letter is followed by a [combining overline](https://unicode-explorer.com/c/0305)). This is tracked in https://github.com/typst/typst/issues/1524.