Matthias Köppe

Results 771 comments of Matthias Köppe

Positive review from me for the changes merged from https://github.com/sagemath/sage/pull/37884 (by @tornaria).

Merged the latest version of #37884

Does not build yet; https://github.com/discopt/cmr/issues/29

In `-minimal` configurations, our boost is too old or too cropped ``` [cmr-git] /sage/local/var/tmp/sage/build/cmr-git/src/src/cmr/matroid.hpp:7:10: fatal error: boost/numeric/ublas/matrix.hpp: No such file or directory [cmr-git] #include [cmr-git] ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ [cmr-git] compilation terminated. ```

Rebased away from the boost upgrade, updated CMR to latest

I've adapted the interface to the new CMR version. There are a few doctest failures that I don't understand ``` sage -t --random-seed=129552849186103186121087193282398427711 src/sage/matrix/matrix_cmr_sparse.pyx ********************************************************************** File "src/sage/matrix/matrix_cmr_sparse.pyx", line 734, in...

Also I haven't done anything yet on the Python side about the new terminology "equimodular" that CMR now uses.