Michael Kleen
Michael Kleen
I may add more tests as a follow-up and see if there are special case where this does not work.
retest this please
retest this please io.crate.integrationtests.MetadataTrackerITest is failing
> LGTM, Please add those comments to explain the LinkedHashMap and the order of static vars declaration. > > Also a question, do you think it's better keeps those tests...
> > Ah, inside the code ? I thought just here for the review. > > Yes please, so no one tries to change that in the future, or at...
> Also a question, do you think it's better keeps those tests executed as integ tests, or could also be moved to just planner tests? In this specific case, i...
retest this please `IndexRecoveryIT.testTransientErrorsDuringRecoveryAreRetried` failure is unrelated.
retest this please
I found this paper on this subject. It mentions group-joins were we would use one hashtable for the inner-join and the group-by together to provide significant performance speed-ups. References: https://link.springer.com/content/pdf/10.1007/s00778-022-00765-x.pdf
> I think this is what @mkleen referenced with https://link.springer.com/content/pdf/10.1007/s00778-022-00765-x.pdf. This paper describes an approach called group-join where the group-by and the hash-inner-join are done with one hash table. We...