Michael Kleehammer comments

Results 105 comments of


                                            Michael Kleehammer

Bug in Cursor_dealloc if cursor close raises an exception

OK. I thought this was benign, but a simple implementation wreaked havoc. I'll look into the details of exceptions and destructors in the 5.0 Python 3 only release.

Decimal results incorrect depending on locale

The comments indicated that the "proper" way to read using a binary format weren't working for all database. Maybe the 5.0 version should default to binary but have a function...

pyodbc, macOS, and iODBC

Closing due to inactivity. Please reopen if this is still an issue.

pyodbc.Binary - Is it something a user would normally need to use?

Then I'll close it. Thanks.

A few improvements to the header files.

I was not aware of the need for the second bullet. It sounds like we should split the headers into two - one with the very basics that can ship...

docs: add more TRACE calls for easier debugging

Looks good, but I added 3 comments in the Files changed tab using the web UI. Can you take a look at those? Thanks.

Continuous fuzzing by way of Google's OSS-Fuzz

Please do integrate - it seems like a good idea. Let's use [email protected] for it. Thanks.

Inconsistent error tuples

That is a problem. Also, I'd rather be able to get at the SQLSTATE directly via `ex.sqlstate`. I wanted to end the 4.x line, but I would consider swapped constructor...

feat: add [pyodbc] and timestamp to tracing output

Makes sense... I should have done that originally. Thanks.

set statement attributes

It does seem like a missing piece of the API - thanks. Could you add at least one test for PostgreSQL, MySQL, or SQL Server? I'm also curious about the...