Mathias Kende
Mathias Kende
This shoud be ready for another round of review at your convenience (I’m not sure what notification is sent by Github).
Thanks, please take another look. (I’m not sure why the CI is failing, the messages seem unrelated to the change as they are about some docker initialisation error)
Any chance to get a new review? I believe that I have addressed all your comment and that this might be ready to be merged.
Let me know if there are still issues to address here.
If there are no more comments on this PR, could it be merged?
Hi Mojolicious maintainer Even if you don’t have the time to review this now, could you tell me if this PR seems reasonable and whether it could accepted or if...
The new reserved stash value is now documented in Mojolicious/Controller.pm, let me know if it should be added somewhere else. As far as I can tell, the interaction with the...
> Template cache names would be an full_path_to_template_file instead of file name currently. There are many things from old times that need requirements to rewrite template cache names. Do you...
> #1630 Can you elaborate on what you mean? As far as I understand, templates are cached by names today and this PR does not change that. For templates referenced...
Are you saying that this existing issue of cache key collision should be fixed in this PR? Otherwise I’m not sur what you mean. As far as fixing that bug,...