Michael K. Edwards

This is probably not the right place to leave this comment, but I haven't found a better one. Suggestions as to better venues are welcome. What I would find really...

Not entirely. It's still useful to have a SAX-style interface by which the Layout can stream JSON events to the Appender.

I've rebased in the `nexiahome:v0.15-streamable` branch, which has all the changes that we're running with locally. Would you like me to pick each out as a separate PR?

The Streamable interface is intended to be generally useful, especially if it's adopted by log4j2 upstream. See https://github.com/nexiahome/formatted_data_message/blob/logstash-streamable/src/main/java/org/apache/logging/log4j/message/lazy/FormattedDataMessage.java#L552 for how we implement `streamTo()`; I think it's very much in the...

But now that you have the JsonGenerator streaming mechanism in the LogstashLayout resolver, I think you want https://github.com/vy/log4j2-logstash-layout/commit/a87707fa5e264b59bc7f05b6e1ffa3739d86390b instead of the implementation in this PR.

That, plus the two commits you identified, are indeed all the substance of that branch.

And what I meant was that it's still useful to have a SAX-style interface by which the _Message_ can stream JSON events to the _Layout_. 😝

Again, context in case it's helpful: we're using this together with some `DynamicThresholdFilter` machinery that lets us selectively log at debug/trace level for devices/sessions of particular interest. Some of the...

retest this please