Michael Kavulich
Michael Kavulich
I'm opening this PR for review! There are a few failing tests but I believe that just requires updates to the test files; I will work on this tomorrow. All...
I have fixed the failing unit tests...I forgot that templates can be passed to retrieve_data.py, so the literal output_path didn't exist. I changed this script to just make the directories;...
Okay, so one of the tests is still failing. @MichaelLueken I will need some help on this, because I can not replicate this unit test failure on Hera.
@MichaelLueken Is there some way to get more information about this error? I can't tell from the output what line is failing, what the input is, etc. It's very hard...
@MichaelLueken From what I can tell this is a problem with the test, not my changes. My changes include logic to ensure that symlinks that are created via `generate_FV3LAM_wflow.py` are...
@MichaelLueken I could also pull this `create_symlink_to_file` change out into its own PR; I'd really like to include it but I don't want that to be the thing holding up...
@MichaelLueken I wasn't able to retrieve the fix file data because there wasn't enough disk space on the standard GitHub runner. I was able to get the tests to pass...
@gsketefian that's correct, if a bug fix is needed for those non-00z ob times then we can apply it to the release branch after the slush. But we should probably...
@MichaelLueken I am seeing a failure after my last round of suggested changes; I will let you know when this is ready for testing.
Okay @MichaelLueken @christinaholtNOAA @gsketefian I have now applied what I think are the final changes, and all verification and fundamental tests are passing on Hera. I think this PR is...