Mark Stapp
Mark Stapp
I'm a bit uncertain what this PR represents. If this were a proposal for how to approach operational data, I'd expect to see a detailed description of the approach, the...
I think the problem was around `eigrp_write()`: it asserts if it doesn't find any work to do, and it's run both as an async, scheduled task and synchronously via `event_execute()`....
> can you share a link to the PR please? the PR was merged just yesterday, in fact, so the change is now in master
I'm a little uncertain what this nb work means. Is this actually plumbed through zebra - many of the apis look to be stubs? There's no mgmtd connection, right? so...
whoa, whoa - the description here just talks about making a northbound/yang-model change, but there's a number of new pieces of dynamic logic that appears to be switching mpls forwarding...
Please sort out the style warnings and the static-analysis warnings?
In this proposal, the BGP protocol is not involved at all - BGP just acts as the host for a routemap. To me, this feels like an ... experiment, a...
Should we consider adding shims for these apis that may/will change in the future? I'd prefer shims to repeated conditional blocks. > For libyang3, there are some ABI changes, so...
That's hard to understand (at least for me). If you ever reported a problem, the first things you'd be asked for would be show output, and debug output. At this...
It looks like the 'disable-vtysh' is used when cross-compiling, when the clippy tool is being built. That may be a construction of David L's - is it still necessary? or...