Michael Dietz

Results 12 comments of Michael Dietz

Concept and Approach ACK. I plan on updating the test and docs introduced in #22067 to take advantage of this in a follow up PR. So I will try to...

I'm doing some more review/testing of this PR, but when I checkout this PR and rebase to master, I get build error: ```bash wallet/rpcwallet.cpp:3387:45: error: no viable conversion from 'std::pair'...

So in my tests, from this multipath descriptor string: `f"wsh(sortedmulti(M},{f'//*,'.join(xpubs)}//*))"` I have a descriptor that looks like this: ```python { 'descriptor': 'wsh(sortedmulti(2,tpubDCcZnBitiPCBqsdLWx8Lkc2BrsvVTdZU2Gcioi8yY76HrGSvp4oWyxZ5GUKGVcjdv4wzWbfntfLdcEEfVRamhSgwi1ZxgfNtayQ2QEEjfTv/0/*,tpubDCMtV5vMS9Zn2paRcw7o83ytLY7WHMCGYRSDxhz7HWnZ4ix19EQpi7g3wvYxEvuoXRfLy5XpXJP5VEr7qPzS92TWnVrBMPJYzfupdACC6vP/0/*,tpubDDBi5pEGAmG7k8t2udh8vbYb1Zpwnt5E9bxd86z6xR66r6tYH1aXy5J3kxR2NDBWhVzgcyiAjFw3kCbkf8YcxDx4wjsnvKjKu3SfPVi4dzf/0/*))#shfp6kvs', 'descriptor_change': 'wsh(sortedmulti(2,tpubDCcZnBitiPCBqsdLWx8Lkc2BrsvVTdZU2Gcioi8yY76HrGSvp4oWyxZ5GUKGVcjdv4wzWbfntfLdcEEfVRamhSgwi1ZxgfNtayQ2QEEjfTv/1/*,tpubDCMtV5vMS9Zn2paRcw7o83ytLY7WHMCGYRSDxhz7HWnZ4ix19EQpi7g3wvYxEvuoXRfLy5XpXJP5VEr7qPzS92TWnVrBMPJYzfupdACC6vP/1/*,tpubDDBi5pEGAmG7k8t2udh8vbYb1Zpwnt5E9bxd86z6xR66r6tYH1aXy5J3kxR2NDBWhVzgcyiAjFw3kCbkf8YcxDx4wjsnvKjKu3SfPVi4dzf/1/*))#ghxep260', 'checksum': 'e82r9xv3', 'isrange': True, 'issolvable': True,...

In my code I actually have: ```python result = multisig.importdescriptors([ { "desc": descriptor["descriptor"], "active": True, "timestamp": "now", }, ]) assert all(r["success"] for r in result) ``` And that doesn't catch...

I had an error in my tests - it seems everything in this PR is working properly. This works: ```python result = multisig.importdescriptors([ { "desc": descsum_create(f"wsh(sortedmulti({self.M},{f'//*,'.join(xpubs)}//*))"), "active": True, "timestamp": "now",...

Review ACK 796c439. I also lightly used/tested this by running #23308 on top of this as additional test coverage.

I think there may be another silent merge conflict w/ master: ```bash wallet/test/util.cpp:33:37: error: no viable conversion from 'std::pair' to 'std::unique_ptr' std::unique_ptr desc = Parse("combo(" + EncodeSecret(key) + ")", provider,...

Implemented here: https://gist.github.com/mjdietzx/0cb95922aac14d446a6530f87b3a04ce#file-residual_network-py-L59

From keras docs `If you are running on the TensorFlow or CNTK backends, your code will automatically run on GPU if any available GPU is detected.` So sounds like maybe...