mj-xmr

Results 52 comments of mj-xmr

``` But I'm sure that any type of exception would be better than just exit(3) The wallet should save before closing. selsta, won't an exception auto-save it? I don't know....

Please fix the merge conflicts first and allow the new code to pass the **unchanged** previously existing tests. There are possible exceptions to this rule of not touching the tests,...

> Can you at least tell me (even privately) what bugs this is fixing? Otherwise this is possibly a re-write for clarity sake, bordering on a re-write to meet your...

@selsta My review is so shallow, because I'm stuffed with so much other work (*). But if you'd like me to help, I'd gladly create my own version, based on...

Thanks for testing, @reemuru . Yes, there's a lot of potential here, which you can see in the [CBTA report](http://cryptog.hopto.org/monero/health/) . The Doxygen report to the right helps in devising...

As a side note, single threaded tests are preferred, due to multithreaded tests suffering from thread starvation.

@reemuru The correct link to the report [is here](http://cryptog.hopto.org/monero/health/).

@selsta I'd hate to argue all the time about this, but it seems, that you might be hitting some I/O bottlenecks, since the differences on your machine are always smaller.

@jeffro256 Thanks for the test. I should have said it beforehand, but you didn't need to sacrifice your ccache for me though :) Here's a softer and more objective way...