miyazaki2048

通过URL跳转vc时参数设置错误

2

https://github.com/alibaba/BeeHive/blob/ff7aef5707481606c6d107cd00840728bb78075a/BeeHive/BHRouter.m#L401-L407 `finalParams`为了初始化vc的属性，所以` [obj setObject:obj forKey:finalParams]; `应该改成如下 ```objc [finalParams enumerateKeysAndObjectsUsingBlock:^(NSString * _Nonnull key, id _Nonnull val, BOOL * _Nonnull stop) { [obj setValue:val forKey:key]; }]; ```

可能的逻辑错误

2

https://github.com/alibaba/BeeHive/blob/ff7aef5707481606c6d107cd00840728bb78075a/BeeHive/BHRouter.m#L590-L596 这里应该调用的是`[target methodSignatureForSelector:action]` ，而不是`[self methodSignatureForSelector:action]`,这里的self是BHRouter --- https://github.com/alibaba/BeeHive/blob/ff7aef5707481606c6d107cd00840728bb78075a/BeeHive/BHRouter.m#L275-L285 service的selector是限定只能调用实例方法吗？貌似是的，URL中定义并未区分同签名的实例方法和类方法；这里存在矛盾的地方，`canOpenURL `里判断selector时 确又是只判断了类方法 --- https://github.com/alibaba/BeeHive/blob/ff7aef5707481606c6d107cd00840728bb78075a/BeeHive/BHRouter.m#L245-L255 如果打开一个`https://call.service.beehive/BBSGroupServiceImpl.BBSGroupService.groupViewController#push`链接，此处pathComponents值是`[@"/",@"BBSGroupServiceImpl.BBSGroupService.groupViewController"}}]`，会始终被认为flag为NO，应该排除@"/"，应和openURL逻辑一致 https://github.com/alibaba/BeeHive/blob/ff7aef5707481606c6d107cd00840728bb78075a/BeeHive/BHRouter.m#L353-L356

CF指针的内存问题

2

https://github.com/alibaba/BeeHive/blob/ff7aef5707481606c6d107cd00840728bb78075a/BeeHive/BHRouter.m#L71-L75 此处需getReturnValue:返回的是CF对象，需要把所有权转换到OC对象 ```objc void *val; [inv getReturnValue:&val]; id ret = (__bridge id)(val); return ret; ```

BHRUsageJumpViewControler判断错误

1

https://github.com/alibaba/BeeHive/blob/ff7aef5707481606c6d107cd00840728bb78075a/BeeHive/BHRouter.m#L287-L292 isKindOfClasss是对象方法，mClass是Class，此处应该调用`[mClass isSubclassOfClass:[UIViewController class]]`