hello-tiny-box icon indicating copy to clipboard operation
hello-tiny-box copied to clipboard

feat: Add PWA support and improve lighthouse performance

Open mithi opened this issue 4 years ago • 9 comments

Screen Shot 2020-09-01 at 9 18 00 PM

mithi avatar Sep 01 '20 13:09 mithi

Hello, @mithi I would like to contribute. I am a first-time contributor so please guide me. I have good experience in front end especially react and javascript. I have worked on lighthouse performance in the past. :-)

arjita-mitra avatar Sep 01 '20 13:09 arjita-mitra

@mithi is there any contribution guideline for your project? Please share.

arjita-mitra avatar Sep 01 '20 13:09 arjita-mitra

@mithi is there any contribution guideline for your project? Please share.

You can follow the guidelines here: https://github.com/mithi/hexapod/blob/master/CONTRIBUTING.md

Thank you! :)

mithi avatar Sep 01 '20 13:09 mithi

Hey! Please let me know if you have questions regarding this issue! :) Thank you for your interest in contributing to this project!

Here's the contribution guidelines: https://github.com/mithi/hexapod/blob/master/CONTRIBUTING.md

On Tue, Sep 1, 2020 at 9:36 PM Arjita [email protected] wrote:

@mithi https://github.com/mithi is there any contribution guideline for your project? Please share.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mithi/hello-tiny-box/issues/18#issuecomment-684858307, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMX2FP2UQ7H5SKFHDINLKTSDT2ENANCNFSM4QRWXWSQ .

mithi avatar Sep 01 '20 14:09 mithi

Sure @mithi .

arjita-mitra avatar Sep 03 '20 14:09 arjita-mitra

Hello @mithi Can you assign this issue to me? I have started working on it.

arjita-mitra avatar Sep 07 '20 15:09 arjita-mitra

ok sure! Thanks! On Mon, Sep 7, 2020 at 11:10 PM Arjita [email protected] wrote:

Hello @mithi https://github.com/mithi

Can you assign this issue to me? I have started working on it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mithi/hello-tiny-box/issues/18#issuecomment-688383996, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMX2FKCGUNGMJXFCVESZPTSETZWZANCNFSM4QRWXWSQ .

mithi avatar Sep 07 '20 15:09 mithi

Hello @mithi It's been a while I am stuck at this issue, because of this I am unable to test service worker also. Service workers can be tested in production mode only. So I tried to deploy it in a static server following this- https://create-react-app.dev/docs/deployment/ https://create-react-app.dev/docs/making-a-progressive-web-app/

I am getting an error, Uncaught SyntaxError: Unexpected token '<'. I read multiple articles to resolve this issue, but no luck so far. So far I understood its some issue with the homepage url in package.json. This message is important -

The project was built assuming it is hosted at /hello-tiny-box/. You can control this with the homepage field in your package.json.

Below is some reference regarding this issue.

https://github.com/webpack/webpack/issues/2882#issuecomment-280906981 https://stackoverflow.com/questions/54340240/create-react-app-build-uncaught-syntaxerror-unexpected-token https://stackoverflow.com/questions/51071848/blank-screen-for-express-react-app-at-production-uncaught-syntaxerror-unexpect

Any help would be appreciated.

arjita-mitra avatar Sep 08 '20 14:09 arjita-mitra

@mithi My commit https://github.com/arjita-mitra/hello-tiny-box/commit/69591eab8b5dd37e6971786354eeed39c282acef

arjita-mitra avatar Sep 08 '20 15:09 arjita-mitra