hello-3d-world
hello-3d-world copied to clipboard
mithi
feat: Add PWA support
Sure! Thanks :)
On Tue, 1 Sep 2020 at 1:18 AM Sanjeev Sharma [email protected] wrote:
Hello @mithi https://github.com/mithi, I would like to take up this issue.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mithi/hello-3d-world/issues/4#issuecomment-683914199, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMX2FPUMIBGU7ATW5ZNOSDSDPLMPANCNFSM4QQCQJZA .
In package.json, you've mentioned @mithi/bare-minimum-2d as a dependency. But It's not working. I think this is not meant to be a scoped package. You should just write bare-minimum-2d.
Is there a reason for it?
In package.json, you've mentioned
@mithi/bare-minimum-2das a dependency. But It's not working. I think this is not meant to be a scoped package. You should just writebare-minimum-2d.Is there a reason for it?
It's working in my end. Could you take a screenshot?
Yes, you can also use plain bare-minimum-2d
The reason for this is that I published this package both in the npm registry as well as the github registry. The github registry requires that this package should be scoped
See:
- Github registry bare-minimum-2d package: https://github.com/mithi/bare-minimum-2d/packages/352301
- Npm registry bare-minimum-2d package: https://www.npmjs.com/package/bare-minimum-2d
Both should work (as it does on my end), but sure, if it's not working for you, you can try changing it :) @thesanjeevsharma
I am having trouble installing bare-minimum-3d now. It's not available on npm, so I installed it from Github. Installation is complete but if you see under node_modules; 3d is empty.
How can I solve this? Are you planning to publish it soon?
i will publish Bare Minimum 3d on npm tomorrow. On Tue, Sep 1, 2020 at 2:57 AM Sanjeev Sharma [email protected] wrote:
[image: Screenshot (92)] https://user-images.githubusercontent.com/29539278/91755936-8cc74b80-ebe9-11ea-8a55-1f0904358811.png
I am having trouble installing bare-minimum-3d now. It's not available on npm, so I installed it from Github. Installation is complete but if you see under node_modules; 3d is empty.
How can I solve this? Are you planning to publish it soon?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mithi/hello-3d-world/issues/4#issuecomment-683967201, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMX2FKTLBCTIHFHXKCSSE3SDPXCZANCNFSM4QQCQJZA .
ill publish Bare Minimum 3d on the npm registry hopefully within the next 24 hours. Thanks!
On Tue, Sep 1, 2020 at 2:57 AM Sanjeev Sharma [email protected] wrote:
[image: Screenshot (92)] https://user-images.githubusercontent.com/29539278/91755936-8cc74b80-ebe9-11ea-8a55-1f0904358811.png
I am having trouble installing bare-minimum-3d now. It's not available on npm, so I installed it from Github. Installation is complete but if you see under node_modules; 3d is empty.
How can I solve this? Are you planning to publish it soon?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mithi/hello-3d-world/issues/4#issuecomment-683967201, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMX2FKTLBCTIHFHXKCSSE3SDPXCZANCNFSM4QQCQJZA .
@thesanjeevsharma
I have bumped the version @mithi/bare-minimum-3d to 0.1.4 and is now published at the npm registry
see https://www.npmjs.com/package/@mithi/bare-minimum-3d
If you're going to use bare-minimum-2d as opposed to @mithi/bare-minimum-2d don't forget to update App.tsx
https://github.com/mithi/hello-3d-world/blob/33abed11e32dbf1e100e021c12087b6610b78418/src/App.tsx#L3
and package.json
https://github.com/mithi/hello-3d-world/blob/33abed11e32dbf1e100e021c12087b6610b78418/package.json#L9
Thanks! 😄
