bare-minimum-2d icon indicating copy to clipboard operation
bare-minimum-2d copied to clipboard

TODO: Add "on touch listener" to demo3

Open mithi opened this issue 5 years ago • 2 comments

  • [ ] Add a note in demo3 that the interaction only works on desktop in the <DemoSticky /> component https://github.com/mithi/bare-minimum-2d/blob/master/example/src/demo3/demo.js Or it might be better to add an "on touch listener"

  • [ ] Please also remove this weird line space here: https://github.com/mithi/bare-minimum-2d/blob/07f8e0f59965868db0c215d2470d926acf579639/example/src/demo1/demoProps.js#L134-L137

mithi avatar Sep 01 '20 14:09 mithi

Hello! I would like to do this. Could you please tell me how to proceed with the first one?

anuragsati avatar Oct 01 '20 15:10 anuragsati

Hello! I would like to do this. Could you please tell me how to proceed with the first one?

Hey! Thanks for your interest in contributing to this project!

  1. First things first, open this on your desktop browser: https://bare-minimum-2d.netlify.app/demo3 Move your mouse around (hovering) and you will find that the pinwheel will spin.

  2. Try to open it on a mobile device like your phone or ipad and you will notice that you won't be able to do the same.

The goal here is to try to make it work both on touch screens and regular screens. Do you think you'll be able to find out how to do that at make it work?

Please also read the contributing guidelines and the recommended commit style guide! Thank you!

mithi avatar Oct 01 '20 18:10 mithi