Jason Clark

Results 18 comments of Jason Clark

sometime the server would timeout as some instances are slow, therefore we would not add the instance, fixed by adding a config var to control the timeout

there was an issue with init, it should be fixed now, im not seeing the issue locally

> Let me know when this is ready to review again. I just pulled and am still seeing multiple requests to the same instance within seconds of each other: should...

did a bunch of refactoring, should be good now

still have this issue, tried changing samesite to none; strict but still had the same issues, fails in all browsers, the default on most browsers changed from none to lax...

heres the entire auth flow GET /auth/github HTTP/2 Host: localhost:4000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:105.0) Gecko/20100101 Firefox/105.0 Accept: text/html,application/xhtml+xml,application/xml;q=0.9,image/avif,image/webp,*/*;q=0.8 Accept-Language: en-US,en;q=0.5 Accept-Encoding: gzip, deflate, br Connection: keep-alive Cookie: __session_key=SFMyNTY.g3QAAAABbQAAAAtfY3NyZl90b2tlbm0AAAAYTWkwTmZFblZjY1RxUUZteG5zM0hBT0M2.SzEZMNeVO2tZ_mbesbYqxo-6Fj7a7lkvmotEt2-YH2s...

the only warning i see is Cookie “__session_key” does not have a proper “SameSite” attribute value. Soon, cookies without the “SameSite” attribute or with an invalid value will be treated...

i fixed this by noticing my callback was running 2x, this was due to a failure in the callback of the controller i was running returning an unexpected response so...