mitchmindtree

Results 396 comments of mitchmindtree

Up to you! I don't mind reviewing them all at once if that's easier for you :smile_cat:

Yeah I think that's fine if its just a `dev-dependency` :+1:

> If I understand correctly, the purpose of this crate is to provide a convenient API for the “I don’t care how you decode this file, please just give me...

Splitting up containers and payloads does sound like it could make sense. Will this complicate the format feature gating much? e.g. would we have have the `flac` feature automatically enable...

You're right, support for writing to non-interleaved buffers hasn't yet been added, though it would be a welcome addition! Currently `StreamParameters` takes an `is_interleaved` `bool` at runtime (which is unhandled...

Thanks for the heads up! I must have accidentally referenced this pr number instead of another in that commit. I'll re-open this. I have had some other thoughts regarding this...

> If that's the case, I'd love to help out and "const generic"-ify the internals of dasp. @linclelinkpart5 please feel free! Exciting times in Rust land to have const generics...

Sorry about the wait @julientregoat, and thanks for your work on this! I think the direction you're going in makes sense. The `i32` support seems pretty straight forward, but yes...

Agreed, I'd also welcome better support for metadata :+1: I wonder how we should go about exposing this metadata in a friendly way? Perhaps before diving in, it would be...

Ahh nice, I agree this would be quite useful to have. This makes me wonder if we should add `Signal::map` and `Signal::zip_map` (that wrap `Frame::map` and `Frame::zip_map` respectively) as a...