Mitchell Hashimoto
Mitchell Hashimoto
This should probably also set the library path, since its all consistent on macOS.
I pushed a rebase, no other changes.
I think I remember this having some bugs which is why I didn’t merge after my original feedback was addressed. I’ll have to double check.
Thanks again! I reviewed this, made some changes, and pushed them as #8402 because I couldn't modify this PR. Original authorship was maintained. I'll merge that once CI passes.
Reproduced. Thanks.
Fixed by #9090
We now have the automation in place to request review properly and I'd like to move forward with merging these. Thank you and sorry for the wait. @RubenRME do you...
I'm down to give this a try. Its a good time before release to merge this, put our ear on the ground and see if anything pops up.
Just noting I'm going to wait to review this until after 1.1.
This is a good proposal, I think having inconsistent tabs in the quick terminal to make tabs work in the quick terminal is a completely fine compromise. I'm sorry I...