macOS: Add support for quick terminal sizing configuration
Resolves #2384
Since support for customizing the initial size for the quick terminal has already been added for linux, I just had to expose the configuration to Swift with the C bindings.
Through the new QuickTerminalSize struct the user's custom configuration is used to set the height and width of the quick terminal. It supports pixels or percentage. It also supports a custom width for the quick terminal through the configuration.
EDIT to Include Demos
Adjusting Height
Adjusting Height and Width
I broke some things with manually resizing the quick terminal window. I am working on fixing that.
Here are some examples of the configurable and more adjustable quick terminal. I decided to expand the quick terminal on both sides when the width (for terminal from top, bottom, center) or height (from left, right, or center) is adjusted.
75% 75% and Adjustments from Top
75% 75% and Adjustments from Right
75% 75% and Adjustments from Center
No Config
I pushed a rebase, no other changes.
Thanks for your feedback and for rebasing it. I just implemented your suggestions and pushed the update.
Is there anything I can do to move this PR forward?
I think I remember this having some bugs which is why I didn’t merge after my original feedback was addressed. I’ll have to double check.
I think I remember this having some bugs which is why I didn’t merge after my original feedback was addressed. I’ll have to double check.
Let me know if you find any. This is a feature I'm really looking forward to having and would like to see it ship with 1.2.
Thanks again! I reviewed this, made some changes, and pushed them as #8402 because I couldn't modify this PR. Original authorship was maintained. I'll merge that once CI passes.