Mitchell Goff
Results
3
comments of
Mitchell Goff
> @mitchellgoffpc any validation you want to do before merging this? Yeah we should verify that it doesn't impact model performance, will run those tests tomorrow morning.
@adeebshihadeh lgtm, model behavior appears to be pretty much identical
> I like the negative slicing behavior, what's the reasoning to remove it except that it matches numpy? This was my thinking: 1) The current implementation mixes negative indexing behavior...