Peter Johnson

Results 1014 comments of Peter Johnson

I did some quick performance testing and it seems that `Set` performs better and the performance is more linear as the size of the dictionary increases: https://jsperf.com/set-vs-object-as-sets/15

I think it's because those benchmarks (which I copied from someone else) also have a value check (` ^ 0` or `!!`) which means they are doing two operations. The...

For the prefix checks, I will write a little [FST](https://www.elastic.co/blog/you-complete-me) memory structure which will make those much faster, in the meantime they can just use iterators and it will be...

Added FST in https://github.com/pelias/parser/pull/17

``` Onion Space - venue ExRotaprint - campus Gottschedstraße 4 - address Aufgang 4 - entrance stairwell 1. OG rechts - first floor right (obergeschoss) 13357 - postcode Berlin -...

In general, I would like to hold off making the switch from the deprecated [`elasticsearch`](https://www.npmjs.com/package/elasticsearch) npm module to the newer [`@elastic/elasticsearch`](https://www.npmjs.com/package/@elastic/elasticsearch) one until it can be better tested. This repo/branch...

Worth mentioning it works as expected for similar streets: ``` Am Falkplatz (0.98) ➜ [ { street: 'Am Falkplatz' } ] Am Wassen (0.38) ➜ [ { locality: 'Wassen' }...

Is it one of these quotes? https://github.com/pelias/parser/blob/master/tokenization/split_funcs.js#L10 The Pelias parser treats those quotes as word boundaries, although there is a code comment below noting that this should only be for...

I'm not sure if this is a data error or a code error, surely 'apostrophe' is the correct character to use? > a mark ' used to indicate the omission...

Agh ok, thanks for posting that link, we're definitely in this situation of "difficulty of software distinguishing which character is intended by a user's typing". I don't have the time...