Peter Johnson

Results 1014 comments of Peter Johnson

I'm not sure if [S2Polygon::GetCellUnionBound](https://github.com/google/s2geometry/blob/master/src/s2/s2polygon.cc#L600) actually removes holes from the `CellUnion` or not 🤷‍♂️ I was a bit disappointed to see that the Go Port [(p *Polygon) CellUnionBound()](https://github.com/golang/geo/blob/master/s2/polygon.go#L665) function returns...

I might have had the wrong assumptions about `RegionCoverer`, I assumed it would cover the surface of the shape rather than the exterior boundary, looking at the C++ code that...

I found this function `GetInteriorCovering()` which solves my issue 🎉 ```cpp auto outer = MakeLoopOrDie("-35.364:153.207, -35.364:158.207, -32.364:158.207, -32.364:153.207"); auto inner1 = MakeLoopOrDie("-34.364:154.207, -34.364:155.207, -33.364:155.207, -33.364:154.207"); auto inner2 = MakeLoopOrDie("-34.364:156.207, -34.364:157.207,...

```bash node --version v16.4.2 ``` ```bash uname -a Darwin Peters-MBP-2.fritz.box 19.6.0 Darwin Kernel Version 19.6.0: Thu Jun 18 20:49:00 PDT 2020; root:xnu-6153.141.1~1/RELEASE_X86_64 x86_64 ```

I think there's an error in my usage where I'm duplicating the start and end points of the loop, removing the end points unfortunately doesn't seem to help with the...

After spending a bit of time with the C++ API, I think this is a simple matter of moving [these lines](https://github.com/radarlabs/s2/blob/master/src/builder.cc#L48-L51) to the constructor.

here some hard data: for sake of simplicity, in my examples I used `way` elements which are part of a relation in the file. the problem effects any element with...

I hate to be the bearer of bad news but it seems that both the `mapzen` and `geofabrik` extracts contain truncated or corrupted entities. There is also a bunch of...

ha! yea I'm becoming quite the expert :) so you feed the exporter `data/planet.o5m` and then it cuts the extracts from that? is it possible that we cut from a...

right, so I slept on this and I have figured out a way producing valid extracts using option 1. without having memory issues and which can cut small city extracts...