Misha Gusarov issues

Repositories
Issues
Comments

Results 2 issues of


                                            Misha Gusarov

Is pgxpool.Tx.{Commit,Rollback} check for tx.c redundant?

`pgxpool.Tx.{Commit,Rollback}` contain the following snippet (https://github.com/jackc/pgx/blob/v5.7.6/pgxpool/tx.go#L25): ```go if tx.c != nil { tx.c.Release() tx.c = nil } ``` However the documentation for `pgxpool.Conn.Release` says "However, it is safe to call...

filepath.Join prohibits using / even in the first argument

Given the following code: ``` moduleFileName := filepath.Join("/modules", fi.Name()) ``` `gocritic` complains: ``` shared/sandbox/qemurun/qemuinit/linux.go:148:35: filepathJoin: "/modules" contains a path separator (gocritic) moduleFileName := filepath.Join("/modules", fi.Name()) ``` I guess it would...