Lena Morita

Results 92 comments of Lena Morita

> the subcomponents in Storybook don't show any props in the docs tab, is that expected? Huh, that's strange. `PanelBody` isn't typed yet, but `PanelRow` is showing a props table...

> I noticed that there a few mentions in the component's docs about the fact that the component internally renders a `table` / `td` / `tr` — do you think...

> * `Element` to `HTMLElement` ([convo](https://github.com/WordPress/gutenberg/pull/47516#discussion_r1094202099)) Addressed in d30ea0b9 (That was easy! 😄)

Dennis has a good point, we need to clarify what we're discussing. What _I_ thought I was discussing when I suggested the `usePrevious` is how we were going to improve...

> It's probably more work this way, but are there pitfalls in accepting whatever seems reasonable as the "empty" value for the component No pitfalls, just the downside like you...

> That doesn't help distinguish how the WordPress component would know that it needs to be uncontrolled though. Is that a problem? Our components tend to be used in controlled...

> [__experimentalTheme](https://github.com/WordPress/gutenberg/pull/44668) @mirka This component isn't publicly [exported from the package](https://github.com/WordPress/gutenberg/blob/trunk/packages/components/src/index.js) yet so it should be fine. But I just realized that the readme isn't excluded from the [public docs](https://developer.wordpress.org/block-editor/reference-guides/components/theme/),...

My suggestion is to keep the scope of this PR to the CSs variable issue only, and deal with alphas as a separate issue. This is because I think the...

> I'm not sure if bundlers would be able to tree-shake different components sub-items (ie — if a consumer imports `Navigator.Button`, would it cause to also import the rest of...

Just as the nature of React, I don't think we can assume that everything in a given subtree will be mounted synchronously, especially when it involves components that were authored...