Lena Morita
Lena Morita
> I'm only a bit reluctant on adding a prop that is explicitly tied to the visual aspect of the component, which may change over time and make that prop...
> What about a `variant` prop that accepts an enum of possible values, i.e. `default` and `minimal` (for the borderless version) ? Or any other better name. Given Joen's guidance,...
@ciampo The facade component refactor is a bit too big for the scope of this PR, so if it's ok with you I'd like to merge this PR in the...
> It's not super easy to check for regressions re. size, label and tooltip behavior on the remaining Storybook stories because of the mix of knobs and controls Yeah, I've...
> Also noting that e2e may be related, since they're flagging an issue with the Font Size Picker tests It was 😱 I'm so glad there was a test that...
> Yes. There is an [ongoing initiative](https://github.com/WordPress/gutenberg/issues/41973) to update all inspector controls to occupy 40px vertical height. So I suppose it's a question of whether we want to implement this...
> I'd be tempted to determine a new list of what we should be testing for `Tooltip` based on user behavior and interactions (WDYT, @mirka ?) Looking at these tests,...
I think we can close this tracking issue now that we are practically done! At the component level, we only have the migration to `CustomSelectControl` v2 left, which is progressing...
I'm having the same issue. Pretty sure it has to do with Spotify starting to [block unauthenticated calls](https://developer.spotify.com/news-stories/2017/01/27/removing-unauthenticated-calls-to-the-web-api/) to the search API. (I had to rewrite my own Spotify-related scripts...
> Changes look good to me - one question I have though is should the `stories` and `test` files also be converted to `.ts{x}`? You're right, most of the test...