Deni Mintsaev
Deni Mintsaev
I'm not quite understanding the indentation changes. It looks like 4 spaces were replaced with 4 spaces, at least in the GitHub diff.
Is there anything unstable about this lint rule anymore?
Would this make the following test setup work? Or would it still be necessary to specify the casing a second time? ```ts // Source: https://github.com/drizzle-team/drizzle-orm/discussions/4216 vi.mock("~/server/db/provider.ts", async () => {...
Please wait until we fully discuss this in the issue 🙏
Can this be merged please?
> I am strongly against this. Can you explain why?
I actually just had an even better and more concise idea that doesn't require us resolving this argument: changing "person" to "p". For example: 333bf_2_person_relay -> 333bf_2p_relay, miniguild_2_person -> miniguild_2p....
@jfly is it okay if I open up a PR with the following changes? 333bf_2_person_relay -> 333bf_2p_relay 333bf_3_person_relay -> 333bf_3p_relay 333bf_4_person_relay -> 333bf_4p_relay 333bf_8_person_relay -> 333bf_8p_relay miniguild_2_person -> miniguild_2p As...
@jfly where would we write such a style guide?
@jfly would you like me to draft that style guide? If so, what are some of the points you'd want to see on there?