Michael Niksa
Michael Niksa
> Do we think I'm actually qualified to review the implementation of a basic collection like that in c++? Or should I lean on the fact that the tests passed...
Do you know how to get a WPR trace of it? @skyline75489 might be able to help you get one. It would be interesting to see if it's something we're...
@DHowett-MSFT, this is another one we're not going to be able to land.
https://github.com/microsoft/terminal/commit/90a24b20b8d27edbc8451936d215cf111cfe3164 is my attempt at experimenting to see if we can make this go even faster by breaking the locking that is occurring here. For `big.txt` from #1064 (which is...
> Yes, IMO it's definitely worth it. The display/rendering should never block IO/CPU operations (as it happens now if I understood correctly). Well... I can't have it "never" block IO/CPU...
@eryksun I'm working on this here if you want to peek: https://github.com/microsoft/terminal/blob/dev/miniksa/env/src/inc/til/env.h I can't say I've addressed all your concerns yet, but I have tried to replicate the spirit of...
> @miniksa, Windows uses reserved environment variables with names that begin with "=", which effectively makes them hidden variables in most cases. This isn't a problem in practice, given an...
[GetSystemPowerStatus](https://docs.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-getsystempowerstatus) and [Registering For Power Events](https://docs.microsoft.com/en-us/windows/win32/power/registering-for-power-events) will help us here.
There's a fix that didn't make RS2 RTM. I'm looking into what we can do about it.
@rprichard The problem is that ReadConsoleOutput* is going to give you different information depending on whether the original text was written with WriteConsoleOutputA, WriteConsoleOutputW, WriteFile, WriteConsoleA, or WriteConsoleW AND whether...